Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commerce Marketplace Integration #1

Open
wants to merge 6 commits into
base: 7.x-1.x
Choose a base branch
from

Conversation

glassdimly
Copy link

Hello aviindub,

I've made what I think are a few small changes to Commerce Stripe that open the module up to interactions with other modules via drupal_alter. Adding these drupal_alters can open up Commerce Stripe to other modules without forking.

If you browse the Drupal universe, there are a couple of modules that fork Commerce Stripe and essentially alter the charge parameters passed to Stripe_Charge::create(). (i.e. Commerce Stripe Connect Field).

With these two drupal_alters and some changes to the classes in the javascript, I can allow users to connect their own Stripe accounts to their stores and charge them directly, sending an application fee back to the main stripe account. My code is still alpha, but the changes to Commerce Stripe are solid. Here's my module, Commerce Marketplace Stripe, which uses Commerce Marketplace. The creator of Marketplace works for Commerce Guys and thus Marketplace likely has a future.

If you are interested, there are a fair number of features that I plan to add as well, including refunds and beefing up Stripe's reporting features. I can work in my own module or contribute them back to Commerce Stripe as you prefer.

@glassdimly
Copy link
Author

If these changes look reasonable, I can re-roll against your latest, if you'd like.

@lu3do
Copy link

lu3do commented Nov 10, 2016

+1 for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants